vendor/template/nsh: Remove NSH_LINELEN
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
JianyuWang0623
requested review from
xiaoxiang781216 and
GUIDINGLI
as code owners
xiaoxiang781216
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
NSH_LINELENfor vendor/template/nsh,NSH_LINELENwas replaced withLINE_MAX.LINE_MAX(default 64 or 80): https://github.com/apache/nuttx/blob/master/libs/libc/unistd/Kconfig#L133NSH_LINELEN: apps/nshlib: Remove the deprecated configNSH_LINELENapache/nuttx-apps#2945Impact
vendor/template
Testing
CI