mtp-responder: Break loop when usb hang up and add debug info #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Output:
mtp-responder/src/mtp_inoti_handler.c: In function '__process_inoti_event':
mtp-responder/src/mtp_inoti_handler.c:195:28: warning: format '%d' expects argument of type 'int', but argument 5 has type 'uint32_t' {aka 'long unsigned int'} [-Wformat=]
195 | ERR_SECURE("Event len is invalid[%d], event->name[%s]\n", event->len,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~
| |
| uint32_t {aka long unsigned int}
/n62s.rel3.5.0314/apps/frameworks/utils/include/log/log_system.h:129:34: note: in definition of macro 'SLOGE'
129 | __VA_ARGS__))
| ^~~~~~~~~~~
mtp-responder/src/mtp_inoti_handler.c:195:17: note: in expansion of macro 'ERR_SECURE'
195 | ERR_SECURE("Event len is invalid[%d], event->name[%s]\n", event->len,
| ^~~~~~~~~~
mtp-responder/src/mtp_inoti_handler.c:195:51: note: format string is defined here
195 | ERR_SECURE("Event len is invalid[%d], event->name[%s]\n", event->len,
| ~^
| |
| int
| %ld
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
… exit Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
JianyuWang0623
requested review from
xiaoxiang781216,
GUIDINGLI and
Donny9
as code owners
xiaoxiang781216
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Break loop when usb hang up and add debug info
Impact
mtp-responder
Testing
CI