Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtp-responder: Disable device icon by default #1

Merged
merged 1 commit into from
Dec 28, 2024
Merged

mtp-responder: Disable device icon by default #1

merged 1 commit into from
Dec 28, 2024

Conversation

JianyuWang0623
Copy link
Member

Summary

mtp-responder: Disable device icon by default.
Some device not support device icon very well.

image

ap> hexdump /vendor/mtp/device_icon.ico skip=0 count=16
/vendor/mtp/device_icon.ico at :
0000: 00 00 01 00 01 00 00 00 00 00 01 00 20 00 47 9b ............ .G.
ap> hexdump /vendor/mtp/device_icon.ico skip=39757 count=16
/vendor/mtp/device_icon.ico at :
0000: e8 1a 97 c9 00 00 00 00 49 45 4e 44 ae 42 60 82 ........IEND.B`.

Impact

mtp-responder

Testing

Self test with customed board succ.

@JianyuWang0623
Copy link
Member Author

@Donny9 Could you review this PR please ?

@JianyuWang0623
mtp-responder: Disable device icon by default
b4e76f6 
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit aed189e into open-vela:dev Dec 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Donny9 Donny9 Donny9 approved these changes

@xiaoxiang781216 xiaoxiang781216 Awaiting requested review from xiaoxiang781216 xiaoxiang781216 is a code owner

@GUIDINGLI GUIDINGLI Awaiting requested review from GUIDINGLI GUIDINGLI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JianyuWang0623 @Donny9 @xiaoxiang781216