Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Contributor Setup Guide #282

Merged
merged 7 commits into from
Jan 24, 2025
Merged

Conversation

RichardChukwu
Copy link
Contributor

This PR updates the CONTRIBUTING.md file to provide a comprehensive guide for contributors to the OpenTelemetry Protocol with Apache Arrow project. (fixes #281 )

This is an initial draft and includes placeholder sections marked as "TBD" where further information is needed.

Pre-requisites: Detailed installation instructions for required tools like Go, Protocol Buffers, and protoc-gen-go.

Local Setup: Instructions on setting up and building the project locally (TBD sections).

Testing: Guidance on running the test suite, understanding different types of tests, and resolving common failures.

Contribution Guidelines: Best practices for:
-Adhering to coding standards and guidelines.
-Writing clear and meaningful commit messages.
-Including appropriate tests for new features and bug fixes.

Following community standards and style guides.

Instructions for signing the Contributor License Agreement (CLA).

Community Resources: Links to the OpenTelemetry Slack community and additional communication platforms.

Next Steps:

Contributors and maintainers are encouraged to help fill in the "TBD" sections with accurate and specific details for this repository. Feedback and suggestions are highly welcomed!

This update aims to make it easier for contributors to get started with the project and follow best practices while contributing.

Please review and let me know if you have any suggestions or feedback.

Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the updates, and I'd prefer to replace a bunch of the TBDs before they land with links to two other documents that mostly answer the same questions. Thank you!

CONTRIBUTING.md Outdated Show resolved Hide resolved
RichardChukwu and others added 2 commits January 23, 2025 12:28
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
@RichardChukwu
Copy link
Contributor Author

RichardChukwu commented Jan 23, 2025

I like the updates, and I'd prefer to replace a bunch of the TBDs before they land with links to two other documents that mostly answer the same questions. Thank you!

Alright, updated in recent commit

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a recursive definition that you should remove. Otherwise, LGTM.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@jmacd jmacd merged commit 251a213 into open-telemetry:main Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Contributor Setup Guide for OpenTelemetry Protocol with Apache Arrow
3 participants