Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"form" -> "forms" #30

Merged
merged 2 commits into from
Oct 8, 2021
Merged

"form" -> "forms" #30

merged 2 commits into from
Oct 8, 2021

Conversation

kingdonb
Copy link
Contributor

@kingdonb kingdonb commented Oct 7, 2021

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is correct: "the aggregate… forms its desired state…" because aggregate is a singular noun here.

Instead of "forms" though, we could say "comprises" if it feels more clear.

Or better yet, remove all of this redundancy since this is a glossary definition:

- for a system form its desired state which is defined as data 

so it just becomes something like this?:

+ The aggregate of all configuration data that is sufficient to recreate the system so that instances of the system are behaviourally indistinguishable.

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
@scottrigby scottrigby added this to the v1.0.0 milestone Oct 8, 2021
@scottrigby scottrigby merged commit 7153c84 into open-gitops:main Oct 8, 2021
@kingdonb kingdonb deleted the fixup-forms branch October 8, 2021 18:54
@scottrigby scottrigby added the bug Something isn't working label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants