From 9a4e4e4faa32d5a8edac7a59d229f2c4a7f9a0a9 Mon Sep 17 00:00:00 2001 From: Michael Beemer Date: Mon, 4 Dec 2023 16:58:44 -0500 Subject: [PATCH] rephrase requirements based on feedback Signed-off-by: Michael Beemer --- specification.json | 4 ++-- specification/sections/03-evaluation-context.md | 11 ++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/specification.json b/specification.json index ae8d1bce..54b289b7 100644 --- a/specification.json +++ b/specification.json @@ -530,7 +530,7 @@ { "id": "Conditional Requirement 3.2.2.4", "machine_id": "conditional_requirement_3_2_2_4", - "content": "The API MUST have a a mechanism to manage `evaluation context`.", + "content": "The API MUST have a a mechanism to manage `evaluation context` for an associated name.", "RFC 2119 keyword": "MUST", "children": [] } @@ -559,7 +559,7 @@ { "id": "Requirement 3.2.4.2", "machine_id": "requirement_3_2_4_2", - "content": "When the `evaluation context` for a named provider is set, the `on context changed` handler MUST only run on the corresponding provider.", + "content": "When the `evaluation context` for a specific provider is set, the `on context changed` handler MUST only run on the associated provider.", "RFC 2119 keyword": "MUST", "children": [] } diff --git a/specification/sections/03-evaluation-context.md b/specification/sections/03-evaluation-context.md index fbd3b7f2..d32c8ae1 100644 --- a/specification/sections/03-evaluation-context.md +++ b/specification/sections/03-evaluation-context.md @@ -81,16 +81,17 @@ In the static-context paradigm, context is global. The client and invocation can > The API **MUST** have a method for setting `evaluation context` for a provider bound to a named client. -In the static-context paradigm, provider specific context can be defined using the name defined during provider registration. +In the static-context paradigm, provider specific context can be set using the associated name. The global context is used if there's no matching provider specific context. See [setting a provider](./01-flag-evaluation.md#setting-a-provider) for details. ##### Conditional Requirement 3.2.2.4 -> The API **MUST** have a a mechanism to manage `evaluation context`. +> The API **MUST** have a a mechanism to manage `evaluation context` for an associated name. -In the static-context paradigm, it must be possible to create, read, and remove provider specific context. +In the static-context paradigm, it must be possible to create and remove provider-specific context. +See [setting a provider](./01-flag-evaluation.md#setting-a-provider) for details. #### Requirement 3.2.3 @@ -125,6 +126,6 @@ The SDK implementation must run the `on context changed` handler on all register ##### Requirement 3.2.4.2 -> When the `evaluation context` for a named provider is set, the `on context changed` handler **MUST** only run on the corresponding provider. +> When the `evaluation context` for a specific provider is set, the `on context changed` handler **MUST** only run on the associated provider. -The SDK implementation must run the `on context changed` handler on only the specified provider that use the provider scoped `evaluation context` whenever it's mutated. \ No newline at end of file +The SDK implementation must run the `on context changed` handler only on the provider that's scoped to the mutated `evaluation context`. \ No newline at end of file