fix: stop ignoring most of the errors

[Skarlso]

Description

Fixes open-component-model/ocm-project#40

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🎇 Restructuring
• 🐛 Bug Fix
• 📝 Documentation Update
• 🎨 Style
• 🧑‍💻 Code Refactor
• 🔥 Performance Improvements
• ✅ Test
• 🤖 Build
• 🔁 CI
• 📦 Chore (Release)
• ⏩ Revert

Related Tickets & Documents

• Related Issue # (issue)
• Closes # (issue)
• Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help
• Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

• 📜 README.md
• 🙅 no documentation needed

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[github-actions]

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION	NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES	1
MAJOR UPDATES AVAILABLE	0
LICENSE REQUIRES REVIEW	4
HIGH RISK LICENSES	9
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY	0

Detailed Logs: mend-scan-> Generate Report
Mend UI

[ocmbot]

Integration Tests for 600f585 run with result: Success ✅!

[ocmbot]

Integration Tests for 600f585 run with result: Success ✅!

[hilmarf]

I'm quite new to go, so please bear with me.
For those cases, where the method signature doesn't allow to return an error, shouldn't we then at least log them?

[Skarlso]

I'm quite new to go, so please bear with me.

For those cases, where the method signature doesn't allow to return an error, shouldn't we then at least log them?

We can attempt to but it's not always possible because the logger is just present or it would require changing the interface to pass it in which is simply too disruptive.

[ocmbot]

Integration Tests for 4b9a12f run with result: Success ✅!

[ocmbot]

Integration Tests for 4b9a12f run with result: Success ✅!

updated

[ocmbot]

Integration Tests for ea79db6 run with result: Success ✅!

[ocmbot]

Integration Tests for e05a5a0 run with result: Success ✅!

[Skarlso]

@hilmarf can we get on with this, please? I would rather have errors handled than this being stuck in review, forever open over whether or not we log errors.

We can open a separate issue for handling logging but this is already a massive improvement on errors being completely ignored otherwise and not surfaced at all, in most of the cases.

With staff being bogged down and in low numbers, I would rather iterate fast and solve issues as they arise than be in review forever.

[hilmarf]

@hilmarf can we get on with this, please? I would rather have errors handled than this being stuck in review, forever open over whether or not we log errors.

We can open a separate issue for handling logging but this is already a massive improvement on errors being completely ignored otherwise and not surfaced at all, in most of the cases.

With staff being bogged down and in low numbers, I would rather iterate fast and solve issues as they arise than be in review forever.

totally fine with me, but you had a nice pattern for identifying the problematic code areas... now with handling them, but don't logging them, still my fear is, that we silently drop errors and won't even be able to find the problematic coding later on, because there is no search pattern anymore available...

so please: either try to log the errors (and yes, I don't care where those logs might appear) OR at least add a FIXME / TODO comment, where the errors are not populated up.

[Skarlso]

so please: either try to log the errors (and yes, I don't care where those logs might appear) OR at least add a FIXME / TODO comment, where the errors are not populated up.

👍

[ocmbot]

Integration Tests for 8a4d919 run with result: Success ✅!

[Skarlso]

@hilmarf Done. :)