Skip to content

Commit

Permalink
Change the default compressing behavior to false (#604)
Browse files Browse the repository at this point in the history
So far, the behavior was to deducted from the media type (if the media
type contained the suffix gzip, the file was compressed). This is quite
unintuitive especially since a user might quite frequently provide an
already compressed file (such as a helm chart archive).
  • Loading branch information
fabianburth authored Dec 22, 2023
1 parent 8fb075d commit 63afb2d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cmds/ocm/commands/ocmcmds/common/inputs/cpi/helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func NewProcessSpec(mediatype string, compress bool) ProcessSpec {
// Compress returns if the blob should be compressed using gzip.
func (s *ProcessSpec) Compress() bool {
if s.CompressWithGzip == nil {
return mime.IsGZip(s.MediaType)
return false
}
return *s.CompressWithGzip
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ is set to <code>true</code>.
This blob type specification supports the following fields:
- **<code>path</code>** *string*
This REQUIRED property describes the file path to the helm chart relative to the
This REQUIRED property describes the path to the file relative to the
resource file location.
` + cpi.ProcessSpecUsage
}

0 comments on commit 63afb2d

Please sign in to comment.