Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update repository.go #599

Merged
merged 4 commits into from
Feb 19, 2025
+4 −3
Merged

Chore: Update repository.go #599

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a22c5c8
Update repository.go
morri-son Feb 19, 2025
8a2a069
try to get gosec exception working
morri-son Feb 19, 2025
81196f8
get gosec working
morri-son Feb 19, 2025
8fcff68
Merge branch 'main' into morri-son-patch-1
morri-son Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/v1alpha1/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const (
// DefaultRegistryCertificateSecretName is the name of the of certificate secret for client and registry.
DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" //nolint:gosec // not a credential
DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // nolint:gosec // not a credential

Check failure

Code scanning / gosec

Potential hardcoded credentials Error

Potential hardcoded credentials

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical

Hard-coded
secret
Loading
.
)

// Internal ExtraIdentity keys.
Expand Down Expand Up @@ -35,5 +35,5 @@
// Ocm credential config key for secrets.
const (
// OCMCredentialConfigKey defines the secret key to look for in case a user provides an ocm credential config.
OCMCredentialConfigKey = ".ocmcredentialconfig" //nolint:gosec // it isn't a cred
OCMCredentialConfigKey = ".ocmcredentialconfig" // nolint:gosec // it isn't a cred

Check failure

Code scanning / gosec

Potential hardcoded credentials Error

Potential hardcoded credentials
)
3 changes: 2 additions & 1 deletion pkg/oci/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@
}

func (c *Client) constructTLSRoundTripper() http.RoundTripper {
tlsConfig := &tls.Config{} //nolint:gosec // must provide lower version for quay.io
// nolint:gosec // must provide lower version for quay.io
tlsConfig := &tls.Config{}

Check failure

Code scanning / gosec

TLS MinVersion too low. Error

TLS MinVersion too low.
caCertPool := x509.NewCertPool()
caCertPool.AppendCertsFromPEM(c.ca)

Expand Down
Loading