Chore: Update repository.go #599
Conversation
morri-son
added
area/ipcei
Mend Scan Summary: ❌Repository: open-component-model/ocm-controller
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -143,7 +143,8 @@ | |||
| } | |||
|
|
|||
| func (c *Client) constructTLSRoundTripper() http.RoundTripper { | |||
| tlsConfig := &tls.Config{} //nolint:gosec // must provide lower version for quay.io | |||
| // nolint:gosec // must provide lower version for quay.io | |||
| tlsConfig := &tls.Config{} | |||
Check failure
Code scanning / gosec
TLS MinVersion too low. Error
Mend Scan Summary: ❌Repository: open-component-model/ocm-controller
|
Mend Scan Summary: ❌Repository: open-component-model/ocm-controller
|
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| const ( | |||
| // DefaultRegistryCertificateSecretName is the name of the of certificate secret for client and registry. | |||
| DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" //nolint:gosec // not a credential | |||
| DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // nolint:gosec // not a credential | |||
Check failure
Code scanning / gosec
Potential hardcoded credentials Error
| @@ -35,5 +35,5 @@ | |||
| // Ocm credential config key for secrets. | |||
| const ( | |||
| // OCMCredentialConfigKey defines the secret key to look for in case a user provides an ocm credential config. | |||
| OCMCredentialConfigKey = ".ocmcredentialconfig" //nolint:gosec // it isn't a cred | |||
| OCMCredentialConfigKey = ".ocmcredentialconfig" // nolint:gosec // it isn't a cred | |||
Check failure
Code scanning / gosec
Potential hardcoded credentials Error
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| const ( | |||
| // DefaultRegistryCertificateSecretName is the name of the of certificate secret for client and registry. | |||
| DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" //nolint:gosec // not a credential | |||
| DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // nolint:gosec // not a credential | |||
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical
|
are you sure, that the checks are executed on the correct branch/PR? |
that I'm now asking myself, too. But when looking at the action https://github.com/open-component-model/ocm-controller/pull/599/checks?check_run_id=37463785489 and then using the "View all branch alerts" link I'm directed to the security alerts page and the branch is shown as refs/pull/599/merge But to get this confirmed, let's merge the PR and check what the CodeQl checks on push on main will tell us. If they still report issues I have no clue why the no lint comments don't work 🤔 |
Mend Scan Summary: ❌Repository: open-component-model/ocm-controller
|
Description
Try to correct gosec linter exception as the former one was not working (dunno if an extra space after the double slash would have already helped, so I made it an own line and added a space...)