Sync managed cluster label fix

[fxiang1]

• I have taken backward compatibility into consideration.

• Sync managed cluster label fix

[fxiang1]

/uncc @jnpacker

[fxiang1]

/test Go / test (pull_request)

[openshift-ci]

@fxiang1: No presubmit jobs available for open-cluster-management-io/multicloud-integrations@main

In response to this:

/test Go / test (pull_request)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mikeshng]

This looks good but I would add an e2e test just to make sure it's working as expected. The e2e does a full OCM-io registration so the managedcluster is there for the labels to copy.

[fxiang1]

Thanks @mikeshng ! I will work on that.

[mikeshng]

It can come in a different PR if this fix is urgently needed @fxiang1

[mikeshng]

/approve

/lgtm

/hold

Feel free to unhold if you want to work on the e2e in another PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mikeshng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fxiang1]

Thanks Mike, this fix is not urgent so I will include the e2e in this PR.

[xiangjingli]

@fxiang1 @mikeshng I see the unit test coverage report failed though the unit test passed.

Is there any change recently in the codecov/codecov-action@v4?

https://github.com/open-cluster-management-io/multicloud-integrations/blob/034023e093463e1ef9fcbd02e6df7eec17f54604/.github/workflows/go-presubmit.yml#L85C15-L85C40

[fxiang1]

I'm not sure, this worked in the stolostron PR stolostron/multicloud-integrations#204 but fails here.

[fxiang1]

/unhold

[fxiang1]

/retest

[fxiang1]

/test ?

[openshift-ci]

@fxiang1: No presubmit jobs available for open-cluster-management-io/multicloud-integrations@main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fxiang1]

@xiangjingli I figured out the test failure with codecov/codecov-action@v4. Apparently there's a bug codecov/codecov-cli#641 with the latest version 10.1.0 so I reverted us to version 10.0.1 as a workaround until the bug is fixed.

[xiangjingli]

/lgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (034023e) to head (b902f9a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff     @@
##   main   #114   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.