Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gmc e2e #84

Merged
merged 5 commits into from
Jun 7, 2024
Merged

add gmc e2e #84

merged 5 commits into from
Jun 7, 2024

Conversation

irisdingbj
Copy link
Collaborator

@irisdingbj irisdingbj commented Jun 5, 2024

Description

add gmc e2e test

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

jq
we need to have jq installed on CI machine.
sudo apt-get install jq

Tests

e2e

@irisdingbj irisdingbj requested a review from daisy-ycguo June 5, 2024 21:05
Copy link
Contributor

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Generally, I would like the workflow to be more general and put all gmc specific installation/test/delete in the e2e script.

@daisy-ycguo
Copy link
Contributor

The dependency jq is installed in the runner machine.

Copy link
Collaborator

@KfreeZ KfreeZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the typo

@daisy-ycguo
Copy link
Contributor

Forget to mention, please add docker build and docker push as one step in the github workflow.

@irisdingbj
Copy link
Collaborator Author

The dependency jq is installed in the runner machine.

Thanks for this great support

@daisy-ycguo
Copy link
Contributor

One more comment, please use ${{ github.event.pull_request.head.sha }} as the image tag for the gmc images. And use this tag in your docker build, push and test.

Signed-off-by: irisdingbj <shaojun.ding@intel.com>
Signed-off-by: irisdingbj <shaojun.ding@intel.com>
Signed-off-by: irisdingbj <shaojun.ding@intel.com>
@irisdingbj
Copy link
Collaborator Author

irisdingbj commented Jun 6, 2024

MountVolume.SetUp failed for volume "model-volume" : hostPath type check failed: /home/sdp/charts-mnt/models is not a directory need to check the CI machine set up

below is tgi pod spec:
Volumes:
model-volume:
Type: HostPath (bare host directory volume)
Path: /home/sdp/charts-mnt/models
HostPathType: Directory

Signed-off-by: irisdingbj <shaojun.ding@intel.com>
@irisdingbj irisdingbj changed the title [WIP]add gmc e2e add gmc e2e Jun 7, 2024
Copy link
Contributor

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you.

Copy link
Collaborator

@zhlsunshine zhlsunshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@lianhao lianhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daisy-ycguo daisy-ycguo merged commit 5951851 into main Jun 7, 2024
8 checks passed
@daisy-ycguo daisy-ycguo deleted the mce2e branch June 7, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants