-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gmc e2e #84
add gmc e2e #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Generally, I would like the workflow to be more general and put all gmc specific installation/test/delete in the e2e script.
The dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the typo
Forget to mention, please add docker build and docker push as one step in the github workflow. |
Thanks for this great support |
One more comment, please use ${{ github.event.pull_request.head.sha }} as the image tag for the gmc images. And use this tag in your docker build, push and test. |
Signed-off-by: irisdingbj <shaojun.ding@intel.com>
Signed-off-by: irisdingbj <shaojun.ding@intel.com>
Signed-off-by: irisdingbj <shaojun.ding@intel.com>
MountVolume.SetUp failed for volume "model-volume" : hostPath type check failed: /home/sdp/charts-mnt/models is not a directory need to check the CI machine set up below is tgi pod spec: |
Signed-off-by: irisdingbj <shaojun.ding@intel.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
add gmc e2e test
Issues
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
jq
we need to have jq installed on CI machine.
sudo apt-get install jq
Tests
e2e