Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Text2Image e2e helm chart #725

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

yongfengdu
Copy link
Collaborator

There is no mega service for text2image, just add an options to the components.

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

Part of #596

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@lianhao
Copy link
Collaborator

lianhao commented Jan 18, 2025

I'm mostly fine to this, just wondering should we move this to e2e layout, just like others?

@lianhao lianhao added this to the v1.2 milestone Jan 18, 2025
Copy link
Collaborator

@Ruoyu-y Ruoyu-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongfengdu
Copy link
Collaborator Author

I'm mostly fine to this, just wondering should we move this to e2e layout, just like others?

Because the name in GenAIExamples and GenAIComps are the same, in this case we'll have to choose a different name for the Example, I'll use txt2img as the example name.

txt2img is just text2image component with ui.
Add tracking to values file for searchqna and text2image in other repos.

Signed-off-by: Dolpher Du <dolpher.du@intel.com>
@yongfengdu yongfengdu changed the title Add UI to text2image Add Text2Image e2e helm chart Jan 20, 2025
@yongfengdu yongfengdu merged commit 81da6b8 into opea-project:main Jan 20, 2025
11 checks passed
@yongfengdu yongfengdu deleted the txt2img branch January 22, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants