Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docsum: Use docsum-gradio-ui by default #667

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

lianhao
Copy link
Collaborator

@lianhao lianhao commented Jan 3, 2025

Description

Change docusm to use gradio-ui by default. Since gradio-ui doesn't require nginx as the reverse proxy, also make nginx optional in docsum.

Issues

Fixes #637.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • New feature (non-breaking change which adds new functionality)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
@lianhao lianhao requested a review from yongfengdu as a code owner January 3, 2025 06:33
@lianhao lianhao requested a review from Ruoyu-y January 3, 2025 06:33
Copy link
Collaborator

@Ruoyu-y Ruoyu-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongfengdu yongfengdu merged commit 95d6398 into opea-project:main Jan 7, 2025
22 checks passed
@lianhao lianhao deleted the docsum_gradio_ui branch January 8, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci-auto] Change DocSum to use gradio UI as the default
3 participants