Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm-chart: update nginx config and minor changes #607

Merged
merged 1 commit into from
Nov 22, 2024
Merged

helm-chart: update nginx config and minor changes #607

merged 1 commit into from
Nov 22, 2024

Conversation

Ruoyu-y
Copy link
Collaborator

@Ruoyu-y Ruoyu-y commented Nov 22, 2024

Description

  • change the nginx configuration
  • switch the default ChatQnA UI image to svelte version

Issues

#589

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n\a

Tests

n\a

@yongfengdu yongfengdu added this to the v1.1 milestone Nov 22, 2024
lianhao
lianhao reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@lianhao lianhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to align with opea/nginx to add the following lines in nginx config too:

https://github.com/opea-project/GenAIComps/blob/7569e7c9b666656ea73ca2d8d9b5d1e832779732/comps/nginx/nginx.conf.template#L13C5-L17C30

@Ruoyu-y
helm-chart: update nginx config
dc1ff69 
* change the nginx configuration

Signed-off-by: Ruoyu Ying <ruoyu.ying@intel.com>
@lianhao lianhao merged commit 9714cde into opea-project:main Nov 22, 2024
23 checks passed
chensuyue pushed a commit that referenced this pull request Nov 22, 2024
@Ruoyu-y @chensuyue
helm-chart: update nginx config (#607)
5067b89 
* change the nginx configuration

Signed-off-by: Ruoyu Ying <ruoyu.ying@intel.com>
(cherry picked from commit 9714cde)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongfengdu yongfengdu yongfengdu approved these changes

@lianhao lianhao lianhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Ruoyu-y @lianhao @yongfengdu