Remove unused values and change GenAIExamples default #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Changes the default example for K8S manifests for GenAIExamples to always download the model to avoid extra setup requirements for the end users. Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
lianhao
requested review from
zhlsunshine,
KfreeZ and
yongfengdu
as code owners
lianhao
requested review from
daisy-ycguo
and removed request for
KfreeZ and
zhlsunshine
yongfengdu
approved these changes
Sep 5, 2024
KfreeZ
approved these changes
Sep 5, 2024
Yugar-1
pushed a commit
to Yugar-1/GenAIInfra
that referenced
this pull request
Sep 5, 2024
* helm: remove unused values Signed-off-by: Lianhao Lu <lianhao.lu@intel.com> * change GenAIExamples to download models by iteself Changes the default example for K8S manifests for GenAIExamples to always download the model to avoid extra setup requirements for the end users. Signed-off-by: Lianhao Lu <lianhao.lu@intel.com> --------- Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.