Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output streaming support for the whole pipeline in GMC router #278

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

zhlsunshine
Copy link
Collaborator

@zhlsunshine zhlsunshine commented Aug 8, 2024

Description

Output streaming support for the whole pipeline in GMC router.

Issues

#263

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n/a.

Tests

The GMC router service log
image

The output streaming via curl
2 questions:
Q1: What is the revenue of Nike in 2023?
Q2: How about the Nike in 2023?
image

Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Copy link
Collaborator

@KfreeZ KfreeZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this means all the requests are processed in stream?

@irisdingbj
Copy link
Collaborator

Thanks for this! Plz address the points we discussed

  1. buffer size
  2. remove suffix and prefix

@zhlsunshine
Copy link
Collaborator Author

Thanks for this! Plz address the points we discussed

  1. buffer size
  2. remove suffix and prefix

Hi @irisdingbj, done!

Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
@irisdingbj irisdingbj merged commit c412aa3 into opea-project:main Aug 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants