Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rpc): Interop Feat Flag Cleanup - Unused Dependency Warning Fix #244

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Feb 13, 2025

Description

Fixes the unused dependency warning for alloy_sol_types by making the interop feature flag depend on jsonrpsee and client, which it effectively already does since interop traits cannot be used without all three features being enabled.

Closes #230

@refcell refcell requested a review from mattsse as a code owner February 13, 2025 15:48
@refcell refcell added the A-rpc Area: rpc crates label Feb 13, 2025
@refcell refcell requested a review from emhane as a code owner February 13, 2025 15:48
@refcell refcell added the C-chore Category: general cleanup label Feb 13, 2025
@refcell refcell requested a review from clabby as a code owner February 13, 2025 15:48
@refcell refcell self-assigned this Feb 13, 2025
@refcell
Copy link
Contributor Author

refcell commented Feb 13, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell merged commit 4c2060a into main Feb 13, 2025
24 checks passed
@refcell refcell deleted the rf/interop-feat branch February 13, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: rpc crates C-chore Category: general cleanup
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature] Fix Unused Crate Warning in maili_rpc
1 participant