Skip to content

Commit

Permalink
chore(rpc): Interop Feat Flag Cleanup - Unused Dependency Warning Fix (
Browse files Browse the repository at this point in the history
…#244)

### Description

Fixes the unused dependency warning for `alloy_sol_types` by making the
`interop` feature flag depend on `jsonrpsee` and `client`, which it
effectively already does since interop traits cannot be used without all
three features being enabled.

Closes #230
  • Loading branch information
refcell authored Feb 13, 2025
1 parent 0ac3752 commit 4c2060a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
18 changes: 10 additions & 8 deletions crates/rpc/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -70,25 +70,27 @@ serde = [
"op-alloy-rpc-types-engine/serde",
"maili-interop?/serde"
]
interop = [
"dep:thiserror",
"dep:maili-interop",
"dep:async-trait",
]
jsonrpsee = [
"serde",
"dep:maili-genesis",
"dep:maili-interop",
"dep:jsonrpsee",
"dep:getrandom",
"dep:alloy-sol-types",
"dep:op-alloy-rpc-jsonrpsee",
]
client = [
"dep:tokio",
"dep:jsonrpsee",
"dep:maili-interop",
"jsonrpsee",
"jsonrpsee/client",
"jsonrpsee/async-client",
"op-alloy-rpc-jsonrpsee/client",
"tokio",
]
interop = [
"client",
"jsonrpsee",
"dep:thiserror",
"dep:maili-interop",
"dep:async-trait",
"dep:alloy-sol-types",
]
4 changes: 2 additions & 2 deletions crates/rpc/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ pub use api::{
SupervisorApiServer,
};

#[cfg(all(feature = "jsonrpsee", feature = "client", feature = "interop"))]
#[cfg(feature = "interop")]
mod traits;
#[cfg(all(feature = "jsonrpsee", feature = "client", feature = "interop"))]
#[cfg(feature = "interop")]
pub use traits::{ExecutingMessageValidator, ExecutingMessageValidatorError};

0 comments on commit 4c2060a

Please sign in to comment.