Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added context type for when internet search tool is used #3930

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

evan-danswer
Copy link
Contributor

Description

Addresses
https://linear.app/danswer/issue/DAN-1427/internet-search-saying-cant-search-the-internet-after-searching-the

We tell the LLM that what it is seeing are internet search results so it knows not to erroneously tell the user that it can't search the internet

How Has This Been Tested?

tested in UI with 4o and o1

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 4:13am

Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: pref not having multiple copies of strings in the code. Also better that default args like this are not literal strings but global final strings. Slightly more ok to have just strings within a function as it scopes it more but in cases like this, let's use a constant.

@yuhongsun96 yuhongsun96 merged commit 2175691 into main Feb 9, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants