Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue causing file connector to fail #3907

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix issue causing file connector to fail #3907

merged 1 commit into from
Feb 5, 2025

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Feb 5, 2025

Description

https://linear.app/danswer/issue/DAN-1414/file-connector-failing-due-to-successful-doc-ids-=-setupdatable-ids

Document ID modification internal to Vespa -> returning different document IDs than passed in -> causes

        successful_doc_ids = {record.document_id for record in insertion_records}
        if successful_doc_ids != set(updatable_ids):
            raise RuntimeError(
                f"Some documents were not successfully indexed. "
                f"Updatable IDs: {updatable_ids}, "
                f"Successful IDs: {successful_doc_ids}"
            )

to fail.

Also includes some additional comments + enabling re-indexing on the file connector.

How Has This Been Tested?

Tested with a batch of files that I knew previously failed. Then verified it worked after the fix.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:44am

@Weves Weves merged commit 6889152 into main Feb 5, 2025
10 of 12 checks passed
@Weves Weves deleted the fix-file-indexing branch February 5, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants