Add more airtable logging #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rkuo-danswer
approved these changes
Jan 31, 2025
| @@ -256,7 +296,7 @@ def from_db_model( | |||
| ) | |||
|
|
|||
|
|
|||
| class RerankingModel: | |||
| class RerankingModel: # | |||
| for doc in ctx.updatable_docs | ||
| ] | ||
| logger.debug(f"Starting indexing process for documents: {doc_descriptors}") | ||
|
|
There was a problem hiding this comment.
Does this make the line below ... "starting chunking" ... irrelevant?
There was a problem hiding this comment.
imo its fine to keep it in (lets you know that chunking is the first step, although no strong opinion)
| @@ -45,7 +46,17 @@ def __init__( | |||
| def run(self) -> GenerateDocumentsOutput: | |||
| """Adds additional exception logging to the connector.""" | |||
| try: | |||
| yield from self.doc_batch_generator | |||
| start = time.monotonic() | |||
There was a problem hiding this comment.
in the past i've seen that items yielded from generators in a loop are lazily evaluated (aka not processed until first accessed in the loop. Just wanted to double check that the timings printed here are indeed working correctly.
There was a problem hiding this comment.
it does work, not sure exactly the standard behavior here though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tries to make Airtable faster
https://linear.app/danswer/issue/DAN-1384/airtable-indexing-extremely-slow
How Has This Been Tested?
Ran locally, it was faster.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.