fix: transaction for batch_add_ext_perm_user_if_not_exists #3849

devin-ai-integration · 2025-01-30T03:13:24Z

Ensures thread safety + concurrency test

Link to Devin run: https://app.devin.ai/sessions/411edb7f2f7743d2bb408b39bec824eb

Override Linear Check

Note: No Linear ticket needed for this change as it's a direct request from the team.

…oncurrency test Co-Authored-By: Chris Weaver <chris@onyx.app>

devin-ai-integration · 2025-01-30T03:13:26Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
Look at CI failures and help fix them

⚙️ Control Options:

Disable automatic comment and CI monitoring

vercel · 2025-01-30T03:13:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
internal-search	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 30, 2025 10:18pm

Co-Authored-By: Chris Weaver <chris@onyx.app>

…te connections Co-Authored-By: Chris Weaver <chris@onyx.app>

Co-Authored-By: Chris Weaver <chris@onyx.app>

…ect to connection Co-Authored-By: Chris Weaver <chris@onyx.app>

Co-Authored-By: Chris Weaver <chris@onyx.app>

fix: add transaction to batch_add_ext_perm_user_if_not_exists & add c…

d696bc2

…oncurrency test Co-Authored-By: Chris Weaver <chris@onyx.app>

style: fix import ordering in test_users.py

4675859

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 03:19 View deployment

devin-ai-integration bot and others added 2 commits January 30, 2025 03:21

test: use sqlite for unit tests

0051a20

Co-Authored-By: Chris Weaver <chris@onyx.app>

style: fix import ordering in conftest.py

5153f69

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 03:26 View deployment

devin-ai-integration bot and others added 3 commits January 30, 2025 03:30

fix: adapt JSONB type for SQLite in unit tests

75c8543

Co-Authored-By: Chris Weaver <chris@onyx.app>

style: fix formatting in conftest.py

2854432

Co-Authored-By: Chris Weaver <chris@onyx.app>

style: use collections.abc.Generator instead of typing.Generator

4a667ee

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 03:38 View deployment

style: apply black formatting to conftest.py

3539d3b

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 03:41 View deployment

style: add newline between imports and event listener in conftest.py

da8f8ed

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 03:44 View deployment

fix: adapt ARRAY type for SQLite in unit tests

931fb0e

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 03:50 View deployment

chore: remove unused String import

d0f5f5d

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 03:53 View deployment

fix: remove schema prefix for SQLite in unit tests

f8d6f23

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 03:59 View deployment

style: fix whitespace in conftest.py

2d2e69a

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 04:04 View deployment

devin-ai-integration bot and others added 4 commits January 30, 2025 04:06

fix: add SQLite UUID type handling for unit tests

a5418ed

Co-Authored-By: Chris Weaver <chris@onyx.app>

fix: add type annotations to SQLiteUUID class methods

13d4cb7

Co-Authored-By: Chris Weaver <chris@onyx.app>

style: use double quotes for UUID type check

d24528a

Co-Authored-By: Chris Weaver <chris@onyx.app>

style: fix import ordering in conftest.py

40c5dde

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 04:16 View deployment

fix: handle JSONB columns in custom types for SQLite adapter

9d44ac9

Co-Authored-By: Chris Weaver <chris@onyx.app>

fix: update PydanticType handling in SQLite adapter

e35bb5e

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 21:03 View deployment

devin-ai-integration bot and others added 2 commits January 30, 2025 21:07

fix: improve transaction handling and SQLite test setup

eb2a030

Co-Authored-By: Chris Weaver <chris@onyx.app>

fix: improve transaction handling and SQLite test setup

b71c62a

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 21:12 View deployment

devin-ai-integration bot and others added 2 commits January 30, 2025 21:12

style: fix black formatting issues in conftest.py

a975525

Co-Authored-By: Chris Weaver <chris@onyx.app>

style: fix black formatting in conftest.py

0a71509

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 21:17 View deployment

fix: use clear() to safely remove event listeners

701cbed

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 21:23 View deployment

fix: create separate db sessions for each thread in test

c83ab35

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 21:29 View deployment

fix: add missing sessionmaker import in test_users.py

22a10f7

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 21:32 View deployment

devin-ai-integration bot and others added 2 commits January 30, 2025 21:36

fix: improve thread safety in SQLite test sessions

3d90b79

Co-Authored-By: Chris Weaver <chris@onyx.app>

style: remove unused exception variable

66f59b0

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 21:41 View deployment

fix: improve thread safety in SQLite test sessions by creating separa…

9ae7fd2

…te connections Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 21:46 View deployment

fix: correct SQLite connection handling in concurrent test

203c7d4

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 21:52 View deployment

fix: create new connection per thread in SQLite test

42460fa

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 21:57 View deployment

fix: use engine directly in concurrent test instead of trying to conn…

d143efe

…ect to connection Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 22:02 View deployment

fix: improve SQLite connection handling in concurrent tests

2ef78ec

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 22:08 View deployment

devin-ai-integration bot and others added 2 commits January 30, 2025 22:13

fix: pass engine URL instead of engine to thread function

c41c21b

Co-Authored-By: Chris Weaver <chris@onyx.app>

fix: address mypy errors in test_users.py

ee355df

Co-Authored-By: Chris Weaver <chris@onyx.app>

vercel bot deployed to Preview January 30, 2025 22:18 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: transaction for batch_add_ext_perm_user_if_not_exists #3849

fix: transaction for batch_add_ext_perm_user_if_not_exists #3849

devin-ai-integration bot commented Jan 30, 2025 •

edited

Loading

devin-ai-integration bot commented Jan 30, 2025

vercel bot commented Jan 30, 2025 •

edited

Loading

fix: transaction for batch_add_ext_perm_user_if_not_exists #3849

Are you sure you want to change the base?

fix: transaction for batch_add_ext_perm_user_if_not_exists #3849

Conversation

devin-ai-integration bot commented Jan 30, 2025 • edited Loading

devin-ai-integration bot commented Jan 30, 2025

🤖 Devin AI Engineer

vercel bot commented Jan 30, 2025 • edited Loading

devin-ai-integration bot commented Jan 30, 2025 •

edited

Loading

vercel bot commented Jan 30, 2025 •

edited

Loading