Robustify cloud deployment + include initial KEDA configuration #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
changed the title
pablonyx
force-pushed
the
point_to_proper_docker_repository
branch
from
491c24d to
caa2966
Compare
rkuo-danswer
requested changes
Nov 9, 2024
| @@ -146,6 +146,8 @@ def on_celeryd_init(sender: Any = None, conf: Any = None, **kwargs: Any) -> None | |||
| def wait_for_redis(sender: Any, **kwargs: Any) -> None: | |||
| """Waits for redis to become ready subject to a hardcoded timeout. | |||
| Will raise WorkerShutdown to kill the celery worker if the timeout is reached.""" | |||
| if MULTI_TENANT: | |||
There was a problem hiding this comment.
Understand we don't need the checks for multi-tenant/cloud, but conditionals like this should be as high in the call stack as possible, not embedded in tool functions.
There was a problem hiding this comment.
Completely agree! Moved all these checks up to the worker init
rkuo-danswer
approved these changes
Nov 9, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description