Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review: Removal of unused functions and fields #46

Open
bvanjeelharia opened this issue May 2, 2023 · 1 comment
Open

Code review: Removal of unused functions and fields #46

bvanjeelharia opened this issue May 2, 2023 · 1 comment

Comments

@bvanjeelharia
Copy link

Please make sure you remove all the unused functions and fields from the modules.For ex: the function post in nextcloud_base.py is not being used anywhere
iscale-odoo pushed a commit that referenced this issue May 5, 2023
[FIX] Fixed issues: #4, #43, #44, #45, #46. Note that we have WIP for…
c577f4b 
… the test scripts
@bvanjeelharia
Copy link
Author

Is the post function the only unused function? All the fields in the module are being used?

iscale-odoo pushed a commit that referenced this issue Jun 2, 2023
[FIX] Fixed issues: #4, #40, #42, #46
470db27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bvanjeelharia