Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove config sample yaml as part of task template:tidy #1713

Closed
wants to merge 1 commit into from

Conversation

ajaykumar4
Copy link
Contributor

@ajaykumar4 ajaykumar4 commented Jan 19, 2025

task template:tidy
is cleaning up all the files except config.sample.yaml

@onedr0p
Copy link
Owner

onedr0p commented Jan 19, 2025

@onedr0p onedr0p closed this Jan 19, 2025
@ajaykumar4
Copy link
Contributor Author

This file is already moved here

https://github.com/onedr0p/cluster-template/blob/main/.taskfiles/template/Taskfile.yaml#L15

but if config.yaml is copied from different repo, then config.sample.yaml will also exist

@onedr0p
Copy link
Owner

onedr0p commented Jan 20, 2025

I am not following, in the current state if the config.sample.yaml doesn't exist the task in this PR will error saying the file doesn't exist, if someone copied this file back into their repo maybe they want to keep it?

@ajaykumar4
Copy link
Contributor Author

as per this https://github.com/onedr0p/cluster-template?tab=readme-ov-file#-tidy-up
all files and folder related template are moved to .private file, then what is the use of keep config.sample.yaml

@onedr0p
Copy link
Owner

onedr0p commented Jan 21, 2025

It's not kept if you're following the instructions because task init moves the sample config to config.yaml. Therefore the sample config will no longer exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants