Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implements email-passwordless provider #24

Merged
merged 6 commits into from
Jan 23, 2025
Merged

feat: implements email-passwordless provider #24

merged 6 commits into from
Jan 23, 2025

Conversation

tfrg
Copy link
Contributor

@tfrg tfrg commented Jan 22, 2025

What type of PR is this?

  • feature

What this PR does:

  • Added email-based passwordless authentication with Web3Auth.
  • Add createEmailPasswordless method to GnoSocialWalletProvider
  • Added SocialEmailPasswordlessConfigure configuration type required for email authentication
  • Implemented logic to handle extraLoginOptions required on login

jinoosss
jinoosss reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check your response types and typeguards.

packages/sdk/src/providers/gno-wallet/gno-social-wallet.ts Outdated Show resolved Hide resolved
packages/sdk/src/providers/gno-wallet/gno-social-wallet.ts Outdated Show resolved Hide resolved
jinoosss
jinoosss approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jinoosss jinoosss merged commit 9bd3996 into onbloc:main Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinoosss jinoosss jinoosss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfrg @jinoosss