feat: Return Social User information #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinoosss
reviewed
Jan 21, 2025
| @@ -124,6 +124,7 @@ export class GnoSocialWalletProvider extends GnoWalletProvider { | |||
| const openloginAdapter = new OpenloginAdapter({ | |||
| privateKeyProvider: privateKeyProvider, | |||
| adapterSettings: { | |||
| storageKey: 'session', | |||
There was a problem hiding this comment.
It looks good to get the settings from the user.
| @@ -243,4 +246,12 @@ export class GnoSocialWalletProvider extends GnoWalletProvider { | |||
| web3auth.configureAdapter(openloginAdapter); | |||
| return new GnoSocialWalletProvider(web3auth, socialType, [networkConfig]); | |||
| } | |||
|
|
|||
| public async getSocialUserProfile(): Promise<Partial<UserInfo>> { | |||
There was a problem hiding this comment.
A few more things
-
override the
UserInfotype. -
add a function to the
TM2Walletinterface. -
make it possible to call the same function from
adena-sdk.
- We need some guard logic to check if it is an instance of
GnoSocialWallet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does: