Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle infinities #7

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Handle infinities #7

wants to merge 8 commits into from

Conversation

joshmoore
Copy link
Member

see ome/omero-gateway-java#15 (comment)
also includes a general refresh of this repository to match 5.5+ (decoupling, code changes)

@joshmoore joshmoore requested a review from dominikl December 17, 2019 10:29
joshmoore added a commit to joshmoore/omero-blitz that referenced this pull request Dec 17, 2019
If an input is an infinity, then do not perform the conversion.

see:
 - ome/ome-units#7
 - ome/omero-gateway-java#15 (comment)
Copy link
Member

@dominikl dominikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if input is infinite then simply return infinite again? Looks alright 👍

@joshmoore
Copy link
Member Author

@dominikl : do you have a straight-forward method for testing Inf, NaN and PIXELS?

@dominikl
Copy link
Member

Not really. There was an image with Inf sizes on the old merge-ci which I used, see https://trello.com/c/X5egtRjc/3-iviewer-fails-to-load-images-with-pixel-size-nan-or-inf .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants