bump annotate-snippets to 0.10 #188

klensy · 2024-01-11T09:24:36Z

TODO (check if already done)

src/status_emitter.rs

oli-obk · 2024-01-11T10:17:51Z

FIXME: currently there no test fail but should, as previously colors can be switched on\off but not now.

is it detected automatically now? if so, that is fine. If it becomes an issue in tests we can always use a crate for stripping terminal colors

klensy · 2024-01-11T10:31:12Z

is it detected automatically now? if so, that is fine. If it becomes an issue in tests we can always use a crate for stripping terminal colors

Nope, with current PR it always not colored, that why fixme added.

FIXME colors didn't checked, as currently used renderer::plain instead of color choose, and no fail

oli-obk · 2024-01-24T16:02:55Z

Thanks! With your link and info I was able to get colors back

klensy · 2024-01-24T16:27:17Z

Thanks, forgot about this PR.

klensy commented Jan 11, 2024

View reviewed changes

src/status_emitter.rs Show resolved Hide resolved

oli-obk force-pushed the annotate-snippets-0.10 branch 2 times, most recently from 50bdffa to 7685c1c Compare January 24, 2024 15:50

bump annotate-snippets to 0.10

329d5f5

FIXME colors didn't checked, as currently used renderer::plain instead of color choose, and no fail

oli-obk force-pushed the annotate-snippets-0.10 branch from 7685c1c to 329d5f5 Compare January 24, 2024 15:50

oli-obk marked this pull request as ready for review January 24, 2024 15:51

oli-obk merged commit 750637c into oli-obk:main Jan 24, 2024
5 checks passed