Skip to content

Commit a027914

Browse files
Refactoring
1 parent 6e715ca commit a027914

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

src/main/java/ru/olegcherednik/zip4jvm/engine/zip/ZipEngine.java

+6-7
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import java.util.List;
5151
import java.util.Map;
5252
import java.util.Set;
53+
import java.util.UUID;
5354
import java.util.stream.Collectors;
5455

5556
import static ru.olegcherednik.zip4jvm.utils.ValidationUtils.requireNotBlank;
@@ -224,8 +225,8 @@ private void removeOriginalZipFiles() throws IOException {
224225
private void moveTempZipFiles() throws IOException {
225226
for (int diskNo = 0; diskNo <= tempZipModel.getTotalDisks(); diskNo++) {
226227
Path src = tempZipModel.getDisk(diskNo);
227-
Path dest = zip.getParent().resolve(src.getFileName());
228-
Files.move(src, dest);
228+
Path dst = zip.getParent().resolve(src.getFileName());
229+
Files.move(src, dst);
229230
}
230231

231232
Files.deleteIfExists(tempZipModel.getSrcZip().getPath().getParent());
@@ -256,11 +257,9 @@ private static ZipModel createTempZipModel(Path zip, ZipSettings settings, Map<S
256257
}
257258

258259
private static Path createTempZip(Path zip) {
259-
return Quietly.doRuntime(() -> {
260-
Path dir = zip.getParent().resolve("tmp");
261-
Files.createDirectories(dir);
262-
return dir.resolve(zip.getFileName());
263-
});
260+
Path dir = zip.getParent().resolve("tmp_" + UUID.randomUUID());
261+
Quietly.doRuntime(() -> Files.createDirectories(dir));
262+
return dir.resolve(zip.getFileName());
264263
}
265264

266265
private static DataOutput creatDataOutput(ZipModel zipModel) throws IOException {

src/test/java/ru/olegcherednik/zip4jvm/Foo.java

+4-6
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import java.nio.file.Path;
2323
import java.nio.file.Paths;
2424

25+
import static ru.olegcherednik.zip4jvm.TestData.fileBentley;
26+
2527
/**
2628
* @author Oleg Cherednik
2729
* @since 19.10.2022
@@ -30,12 +32,8 @@
3032
public class Foo {
3133

3234
public static void main(String[] args) throws IOException {
33-
Path src = Paths.get("f:/zip4jvm/foo/src/data");
34-
Path zip = Paths.get("f:/zip4jvm/aaa.zip");
35-
36-
// ZipIt.zip(zip).add(src);
37-
UnzipIt.zip(zip).dstDir(Paths.get("f:/zip4jvm/dst")).extract();
38-
35+
Path zip = Paths.get("f:/zip4jvm/zip64/ferdinand2.zip");
36+
ZipIt.zip(zip).add(fileBentley);
3937
}
4038

4139
}

0 commit comments

Comments
 (0)