Remove logic for postion-based argument to the numbers command.
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okamsn
force-pushed
the
remove-numbers-pos-args
branch
from
e8ab7a1 to
ebd6819
Compare
…and. - Simply the definition of `numbers` by no longer accepting those arguments and by using the more recent `loopy--instr-let-const*` and `loopy--instr-let-var*`. - Remove the assumption that the `list` argument of `loopy--only-valid-keywords-p` is a proper plist. - Remove the singly used function `loopy--extract-keywords`. - Modify `loopy--defiteration` to always define the variable `opts` when keywords are used, to always check keyword arguments when keywords are used, to set the internal variable `required-vals` to 0 when it is nil, and to set `other-vals` to nil when it is 0 or a list only containing 0. - Begin updating tests. - Update Org documentation and Texinfo file.
okamsn
force-pushed
the
remove-numbers-pos-args
branch
from
ebd6819 to
73a4262
Compare
github-actions bot
added a commit
that referenced
this pull request
Aug 24, 2024
…e `numbers` command. (#205) This commit was copied from the master branch. Commit: 455c14b Author: okamsn <28612288+okamsn@users.noreply.github.com> Date: 2024-08-24 02:12:24 +0000 Start removing logic for postion-based argument to the `numbers` command. (#205) - Simply the definition of `numbers` by no longer accepting those arguments and by using the more recent `loopy--instr-let-const*` and `loopy--instr-let-var*`. - Remove the assumption that the `list` argument of `loopy--only-valid-keywords-p` is a proper plist. - Remove the singly used function `loopy--extract-keywords`. - Modify `loopy--defiteration` to always define the variable `opts` when keywords are used, to always check keyword arguments when keywords are used, to set the internal variable `required-vals` to 0 when it is nil, and to set `other-vals` to nil when it is 0 or a list only containing 0. - Begin updating tests. - Update Org documentation and Texinfo file.
github-actions bot
added a commit
that referenced
this pull request
Aug 24, 2024
…e `numbers` command. (#205) This commit was copied from the master branch. Commit: 455c14b Author: okamsn <28612288+okamsn@users.noreply.github.com> Date: 2024-08-24 02:12:24 +0000 Start removing logic for postion-based argument to the `numbers` command. (#205) - Simply the definition of `numbers` by no longer accepting those arguments and by using the more recent `loopy--instr-let-const*` and `loopy--instr-let-var*`. - Remove the assumption that the `list` argument of `loopy--only-valid-keywords-p` is a proper plist. - Remove the singly used function `loopy--extract-keywords`. - Modify `loopy--defiteration` to always define the variable `opts` when keywords are used, to always check keyword arguments when keywords are used, to set the internal variable `required-vals` to 0 when it is nil, and to set `other-vals` to nil when it is 0 or a list only containing 0. - Begin updating tests. - Update Org documentation and Texinfo file.
okamsn
changed the title
numbers command.numbers command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply the definition of
numbersby no longer accepting those argumentsand by using the more recent
loopy--instr-let-const*andloopy--instr-let-var*.Remove the assumption that the
listargument ofloopy--only-valid-keywords-pis a proper plist.loopy--extract-keywords.Modify
loopy--defiterationto always define the variableoptswhenkeywords are used, to always check keyword arguments when keywords are used,
to set the internal variable
required-valsto 0 when it is nil,and to set
other-valsto nil when it is 0 or a list only containing 0.Begin updating tests.
Org documentation should not need an update.