cookieRefresh() now independent of NodeJS server #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new function refreshAlexaCookieWithoutRelyingOnTheNodeJsServer() which is able to refresh the Alexa cookie without relying on an external NodeJS server. Modified the refreshCookie() and getCookie() functions so that refreshAlexaCookieWithoutRelyingOnTheNodeJsServer() is invoked when and if the attempt to refresh the cookie using the external NodeJS server fails. Added a bunch of verbiage to the preferences page to explain the cookie refresh process and haw gabriele-v's AlexaCookieNodeJs program fits into the puzzle.
|
I updated the native cookie refresh behavior so that we will now attempt to do a native cookie refresh only if our attempt to refresh the cookie via an external NodeJS server fails. I also added some verbiage to the preferences page to explain the cookie refresh process and how the NodeJS server fits into the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new function refreshAlexaCookieWithoutRelyingOnTheNodeJsServer() which is able to refresh the Alexa cookie without relying on an external NodeJS server.
Modified the refreshCookie() and getCookie() functions so that refreshAlexaCookieWithoutRelyingOnTheNodeJsServer() is invoked when and if the attempt to refresh the cookie using the external NodeJS server fails.
Added a bunch of verbiage to the preferences page to explain the cookie refresh process and haw gabriele-v's AlexaCookieNodeJs program fits into the puzzle.