Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group by dependencies for agg columns #12

Open
oelarnes opened this issue Feb 10, 2025 · 0 comments
Open

Group by dependencies for agg columns #12

oelarnes opened this issue Feb 10, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@oelarnes
Copy link
Owner

Agg columns may depend on group_by columns, for example, you probably want gp_wr_mean to group by expansion by default.

At the moment, 'expansion' will go into the view columns structure according to manifest, but will not be grouped by and therefore passed as part of the agg_df unless it is also specified as a grouping. Probably it should just grouped by and just not selected in the final selection.

@oelarnes oelarnes added the bug Something isn't working label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant