Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancies in the AuditEvent mappings #469

Open
qligier opened this issue Feb 26, 2025 · 1 comment · May be fixed by #470
Open

Discrepancies in the AuditEvent mappings #469

qligier opened this issue Feb 26, 2025 · 1 comment · May be fixed by #470

Comments

@qligier
Copy link
Contributor

qligier commented Feb 26, 2025 •
edited
Loading

A few things I saw when working with AuditRecordTranslator and AbstractFhirAuditSerializationStrategy.

In AuditRecordTranslator, the ActiveParticipant/RoleIDCode is mapped to agent.role. In IHE FHIR profiles (and in AbstractFhirAuditSerializationStrategy), it is mapped to agent.type.
There's a slight issue with the IHE mapping: RoleIDCode and agent.role can be multivalued, but not agent.type. Still, since a single RoleIDCode value is specified in IHE profiles, we should expect only one value.

In AbstractFhirAuditSerializationStrategy, when the AuditMessage comes from a non-FHIR transaction, the subtype.system is "IHE Transactions" instead of the valid urn:ihe:event-type-code.

Still in AbstractFhirAuditSerializationStrategy, the ParticipantObjectID is only mapped to entity.what if it refers to a patient.

PR: #470.
qligier added a commit to qligier/ipf that referenced this issue Feb 26, 2025
@qligier
oehf#469: fix the ActiveParticipant->agent mapping
e8ec958
qligier added a commit to qligier/ipf that referenced this issue Feb 26, 2025
@qligier
oehf#469: fix the IHE Transactions system in AuditEvents
c279311
qligier added a commit to qligier/ipf that referenced this issue Feb 26, 2025
@qligier
oehf#469: always map the ParticipantObjectID to AuditEvents
e78ec4f
@qligier qligier linked a pull request Feb 26, 2025 that will close this issue
Open
@ohr
Copy link
Member

ohr commented Feb 26, 2025

Thanks for submitting this. I will double check the mappings with IHE BALP and provide feedback then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uniformize mapping of ATNA->FHIR translation qligier/ipf
2 participants
@ohr @qligier