Suppress minor warnings

.github/workflows/windows.yml

@@ -45,12 +45,6 @@ jobs:
             std: 17
             with_tests: "OFF"
 
-          - os: windows-2022
-            platform: ARM
-            build_type: Release
-            std: 17
-            with_tests: "OFF"
-
     steps:
       - uses: actions/checkout@v4
 

CHANGELOG.md

@@ -80,6 +80,11 @@
 - [v1.1.0](#v110)
 - [v1.0.0](#v100)
 
+## TBD
+
+- Suppress `-Wredundant-decls` warning in GCC builds.
+- Avoid adding `-Wno-gnu-zero-variadic-macro-arguments` for GCC in CMake.
+
 ## v7.5.0
 
 - In previous versions, logging on Windows automatically included `windows.h` in all components. The frontend will no

CMakeLists.txt

@@ -296,7 +296,7 @@ target_include_directories(${TARGET_NAME}
 
 # Compiler options
 target_compile_options(${TARGET_NAME} INTERFACE
-        $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:-Wno-gnu-zero-variadic-macro-arguments>)
+        $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>>:-Wno-gnu-zero-variadic-macro-arguments>)
 
 # Install
 if (QUILL_MASTER_PROJECT OR QUILL_ENABLE_INSTALL)

cmake/QuillUtils.cmake

@@ -34,7 +34,7 @@ function(set_common_compile_options target_name)
 
     target_compile_options(${target_name} ${COMPILE_OPTIONS_VISIBILITY}
             $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:
-            -Wall -Wextra -pedantic -Werror>
+            -Wall -Wextra -pedantic -Werror -Wredundant-decls>
             $<$<CXX_COMPILER_ID:MSVC>:/bigobj /WX /W4 /wd4324 /wd4996>)
 
     if (QUILL_NO_EXCEPTIONS)

include/quill/core/Codec.h

@@ -28,9 +28,18 @@ namespace detail
 {
 
 #if defined(_WIN32)
+  #if defined(__MINGW32__)
+    #pragma GCC diagnostic push
+    #pragma GCC diagnostic ignored "-Wredundant-decls"
+  #endif
+
 /** We forward declare these to avoid including Utf8Conv.h **/
 extern std::string utf8_encode(std::wstring_view str);
 extern std::string utf8_encode(std::byte const* data, size_t wide_str_len);
+
+  #if defined(__MINGW32__)
+    #pragma GCC diagnostic pop
+  #endif
 #endif
 
 /**

include/quill/core/ThreadContextManager.h

@@ -32,10 +32,19 @@ namespace detail
 class TransitEventBuffer;
 class BackendWorker;
 
+#if defined(__GNUC__) || defined(__clang__) || defined(__MINGW32__)
+  #pragma GCC diagnostic push
+  #pragma GCC diagnostic ignored "-Wredundant-decls"
+#endif
+
 /** We forward declare these to avoid including ThreadUtilities.h **/
 extern std::string get_thread_name();
 extern uint32_t get_thread_id() noexcept;
 
+#if defined(__GNUC__) || defined(__clang__) || defined(__MINGW32__)
+  #pragma GCC diagnostic pop
+#endif
+
 class ThreadContext
 {
 private: