You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per https://multiformats.io/multiaddr/, other addresses might be used beyond the default /ip4/127.0.0.1/tcp/5001 that might have more or less than four parts split by /, e.g., /ip4/127.0.0.1/tcp/80/http.
Additionally, the named values do not seem to match that which is parsed, e.g., ip4 is not the "scheme".
This code should be remedied to be more adaptive to the extent of the variants of mutliaddresses. Does the base library provide any semantic getters of these values rather than trying to parse them?
The text was updated successfully, but these errors were encountered:
This relates to #718 in that while reviewing the PR with @ibnesayeed, noticed the rudimentary, potentially unreliable parsing procedure. The code would be better informed with some test cases, as enumerated in the multiaddr URI above.
In util.py, the IPFS daemon API endpoint is read form ~/.ipfs/config and parsed through
Per https://multiformats.io/multiaddr/, other addresses might be used beyond the default
/ip4/127.0.0.1/tcp/5001
that might have more or less than four parts split by/
, e.g.,/ip4/127.0.0.1/tcp/80/http
.Additionally, the named values do not seem to match that which is parsed, e.g.,
ip4
is not the "scheme".This code should be remedied to be more adaptive to the extent of the variants of mutliaddresses. Does the base library provide any semantic getters of these values rather than trying to parse them?
The text was updated successfully, but these errors were encountered: