Rewrite inlining pass #1935
Open
Rewrite inlining pass #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
force-pushed
the
inlining
branch
3 times, most recently
from
840420d to
7b64a79
Compare
hhugo
reviewed
Apr 15, 2025
vouillon
force-pushed
the
inlining
branch
3 times, most recently
from
79446f9 to
ba1a622
Compare
hhugo
reviewed
Apr 16, 2025
hhugo
reviewed
Apr 17, 2025
vouillon
force-pushed
the
inlining
branch
4 times, most recently
from
b62b39e to
5cb6652
Compare
Rewrite code locations everywhere, so that it can used to duplicate nested functions.
hhugo
reviewed
Apr 25, 2025
| ; body_size : int cache | ||
| ; full_size : int cache | ||
| ; closure_count : int cache | ||
| ; init_code : int cache |
There was a problem hiding this comment.
Could you add a comment to some of these fields explain what there are for ?
At least for init_code, interesting_params, full_size
hhugo
reviewed
Apr 25, 2025
| && (not (contains_loop ~context info)) | ||
| && returns_a_block ~context info | ||
| && count_init_code ~context info * 2 > body_size ~context info | ||
| && full_size ~context info - body_size ~context info <= 20 * closure_count ~context info |
There was a problem hiding this comment.
maybe add a small comment explaining the two heuristics above , init_code * 2 > body_size and full_size <= 20 * closure_count
- We are a lot more aggressive at inlining functor-like functions, since this may enable further optimizations. - We are more cautious at inlining nested functions, since this can result in memory leaks. - We inline a larger class of small functions
|
I've pushed a fixup to the testsuite. |
|
We need a changelog entry |
|
I'm not certain I read the benchmark correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.