[1.21.x] Equipment Integration Abstraction and Accessories Integration #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move Trinkets Compat to Common for Sinytra Connector support for trinkets - Rework integration loading and adjust Platform service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add native support for Accessories by reworking the underlying API to allow for the implementation of other Accessories API based on extendable class.
Other Changes
Reason: Issues with trinkets and curios implementation lead to issues with the compat layers that could be resolved but I decided to abstract away the equipment integration API to allow for others to add support for API if the need for such arises.