Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hope you can use ConcurrentHashMap #342

Open
CaoTrongThang opened this issue Nov 15, 2024 · 2 comments
Open

Hope you can use ConcurrentHashMap #342

CaoTrongThang opened this issue Nov 15, 2024 · 2 comments
Labels
bug Something isn't working. Whoops

Comments

@CaoTrongThang
Copy link

Hey, I'm not good at coding but I've learned about Java a little bit, I think you should use the ConcurrentHashMap, instead of Hashmap in Java, switching to ConcurrentHashMap is easy. I keep getting concurrentmodificationexception crash in the modpack. I decompiled your code and see that you've been using Hashmap, I know that you're a good coder but switching to ConcurrentHashMap shouldn't do any harm to your code.

@CaoTrongThang CaoTrongThang added the bug Something isn't working. Whoops label Nov 15, 2024
@florensie
Copy link
Collaborator

Can you please provide a crash log. I don't see any obvious HashMaps that would need to be concurrent in the code.

@CaoTrongThang
Copy link
Author

thanks for reply me, here's the crash log, I don't know what mod did that.

crash-2024-11-16_01.56.38-client.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Whoops
Projects
None yet
Development

No branches or pull requests

2 participants