Cleanup OpamStd of duplicated functions that already exist in Stdlib #6442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
from
b38f27d to
c592209
Compare
kit-ty-kate
added
the
PR: QUEUED
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
from
c592209 to
20f6dce
Compare
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
from
20f6dce to
3be9b6e
Compare
kit-ty-kate
removed
the
PR: QUEUED
kit-ty-kate
commented
Mar 31, 2025
| @@ -71,7 +71,7 @@ let rec print_env output = function | |||
| | [] -> () | |||
| | (k, v, comment) :: r -> | |||
| if OpamConsole.verbose () then | |||
| OpamStd.Option.iter (Printf.ksprintf output ": %s;\n") comment; | |||
| Stdlib.Option.iter (Printf.ksprintf output ": %s;\n") comment; | |||
There was a problem hiding this comment.
Side note for reviewers: explicit uses of Stdlib is required in opam-client and opam-solver because extlib (used via dose3) shadows the standard library module
kit-ty-kate
added a commit
to kit-ty-kate/opam-rt
that referenced
this pull request
Mar 31, 2025
kit-ty-kate
added
the
PR: QUEUED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queued on #6444Queued on #6394
Requires ocaml-opam/opam-rt#84
A little spring cleaning