Internal repos-config new syntax
#6393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
reviewed
Feb 21, 2025
Comment on lines
+2076
to
+2084
| (fun ~pos:_ repos -> | ||
| let repos, errs = List.split repos in | ||
| let repos = List.filter_map Fun.id repos in | ||
| let map = OpamRepositoryName.Map.of_list repos in | ||
| let errs = List.flatten errs in | ||
| map, errs) | ||
| (fun (map, _errs) -> | ||
| OpamRepositoryName.Map.bindings map | ||
| |> List.map (fun x -> Some x, [])) |
There was a problem hiding this comment.
These two functions can be done more efficiently in one fold each
|
|
||
| # Packages matching: any | ||
| # No matches found | ||
| ### sh -c "rm OPAM/repo/state-*.cache" | ||
| ### opam list -A | ||
| [WARNING] Errors in ${BASEDIR}/OPAM/repo/repos-config, some fields have been ignored: | ||
| - At ${BASEDIR}/OPAM/repo/repos-config:2:16-2:23:: | ||
| expected url | ||
| - In ${BASEDIR}/OPAM/repo/repos-config: |
There was a problem hiding this comment.
what is the reason we're loosing the position here?
There was a problem hiding this comment.
OpamFormat.section does not keep positions
kit-ty-kate
reviewed
Feb 21, 2025
…y are needed from repo/switch driven upgrades
…from repo or switch change
rjbou
added
the
PR: QUEUED
rjbou
commented
Mar 12, 2025
Comment on lines
+1153
to
+1156
| let v2_3 = OpamVersion.of_string "2.3" | ||
|
|
||
| let from_2_2_to_2_3 ~on_the_fly:_ _ conf = conf, gtc_none | ||
|
|
There was a problem hiding this comment.
Not sure that it is needed...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite difficult and misleading to repository related information in the
repos-configfile (like in #4933 and #6283).The current format contain a list with a some optional elements, which complicated the parsing
The PR implements a new syntax for this file: each repository is a section with it's own defined labeled fields:
Adding then a new field is quite easy.
This change implies an hard upgrade (no best effort loading if read only) to update the opam root.
fix #6327
TODO: