chore: rename internal spawn to dune_spawn #11647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/chore__rename_internal_spawn_to_dune_spawn
branch
4 times, most recently
from
33be6a1 to
df7c677
Compare
We shouldn't be using the internal vendored library for anything but bootstrapping dune. For everything else, spawn from opam should be preferred. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 24a1522f-0004-4180-835f-37da0e2cba42 --> Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
ps/rr/chore__rename_internal_spawn_to_dune_spawn
branch
from
df7c677 to
260e7a9
Compare
|
This should fix an issue in |
maxim092001
pushed a commit
to maxim092001/dune
that referenced
this pull request
May 3, 2025
We shouldn't be using the internal vendored library for anything but bootstrapping dune. For everything else, spawn from opam should be preferred. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be using the internal vendored library for anything but bootstrapping dune. For everything else, spawn from opam should be preferred.