Skip to content

Commit

Permalink
fix: linting errors
Browse files Browse the repository at this point in the history
  • Loading branch information
SKairinos committed Jan 15, 2025
1 parent 6efdffa commit 1bac0c2
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 8 deletions.
3 changes: 2 additions & 1 deletion codeforlife/serializers/model_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from rest_framework.serializers import ValidationError as _ValidationError

from ..request import BaseRequest, Request
from ..types import DataDict, OrderedDataDict, get_arg
from ..types import DataDict, OrderedDataDict
from .base import BaseSerializer

# pylint: disable=duplicate-code
Expand Down Expand Up @@ -91,6 +91,7 @@ def create(self, validated_data: t.List[DataDict]) -> t.List[AnyModel]:
Returns:
The models.
"""
# pylint: disable-next=line-too-long
return self.model_class.objects.bulk_create( # type: ignore[attr-defined]
objs=[self.model_class(**data) for data in validated_data],
batch_size=self.batch_size,
Expand Down
1 change: 0 additions & 1 deletion codeforlife/tests/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

import typing as t

from ..types import get_arg
from .api_client import APIClient, BaseAPIClient
from .test import TestCase

Expand Down
2 changes: 1 addition & 1 deletion codeforlife/tests/api_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from rest_framework.response import Response
from rest_framework.test import APIClient as _APIClient

from ..types import DataDict, JsonDict, get_arg
from ..types import DataDict, JsonDict
from .api_request_factory import APIRequestFactory, BaseAPIRequestFactory

# pylint: disable=duplicate-code
Expand Down
3 changes: 1 addition & 2 deletions codeforlife/tests/model_view_set.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,9 @@
from django.db.models import Model
from django.urls import reverse

from ..models import AbstractBaseUser
from ..permissions import Permission
from ..serializers import BaseSerializer
from ..types import DataDict, JsonDict, KwArgs, get_arg
from ..types import DataDict, JsonDict, KwArgs
from ..views import BaseModelViewSet, ModelViewSet
from .api import APITestCase, BaseAPITestCase
from .model_view_set_client import BaseModelViewSetClient, ModelViewSetClient
Expand Down
1 change: 0 additions & 1 deletion codeforlife/views/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from rest_framework.views import APIView as _APIView

from ..request import BaseRequest, Request
from ..types import get_arg

# pylint: disable=duplicate-code
if t.TYPE_CHECKING:
Expand Down
5 changes: 3 additions & 2 deletions codeforlife/views/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from ..permissions import Permission
from ..request import BaseRequest, Request
from ..types import KwArgs, get_arg
from ..types import KwArgs
from .api import APIView, BaseAPIView
from .decorators import action

Expand Down Expand Up @@ -102,7 +102,8 @@ class Meta:
# # pylint: disable-next=too-few-public-methods
# class _ModelListSerializer(
# ModelListSerializer[
# RequestUser, self.model_class # type: ignore[valid-type]
# RequestUser,
# self.model_class, # type: ignore[valid-type]
# ]
# ):
# pass
Expand Down

0 comments on commit 1bac0c2

Please sign in to comment.