Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow binary search of Lookup table #18

Closed
ChristopherRabotin opened this issue May 22, 2022 · 1 comment
Closed

Allow binary search of Lookup table #18

ChristopherRabotin opened this issue May 22, 2022 · 1 comment

Comments

@ChristopherRabotin
Copy link
Member

Due to the (minor) limitations of der's SequenceOf, it is not possible to get a pointer to the underlying array of items. This prevent searching is trivially with a binary search.

Trying to implement a binary search of the hashes requires, at the moment, copying the underlying index at every single call. This is slow.

This requires a solution to RustCrypto/formats#665.
@ChristopherRabotin
Copy link
Member Author

Lookup tables have been removed in favor of using the SPICE files directly. Hence this feature is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChristopherRabotin