Load template translations params #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1206 +/- ##
=======================================
Coverage 87.72% 87.73%
=======================================
Files 260 260
Lines 10870 10876 +6
=======================================
+ Hits 9536 9542 +6
Misses 915 915
Partials 419 419 ☔ View full report in Codecov by Sentry. |
assets/static/template.go
Outdated
| Content_ string `json:"content" validate:"required"` | ||
| Locale_ i18n.Locale `json:"locale" validate:"required"` | ||
| Namespace_ string `json:"namespace"` | ||
| VariableCount_ int `json:"variable_count"` |
There was a problem hiding this comment.
Can't we get rid of variable count? Isn't it just len(params["body"]) ?
There was a problem hiding this comment.
Yes those are the same, I have not seen where that variable is used actually, I guess probably with the flow_editor, so we can cleanup that once we are sure it is not relied on
There was a problem hiding this comment.
I mean get rid of it here if the engine doesn't need it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.