Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braille doesn't work on last snapshot #17502

Open
dreinn opened this issue Dec 11, 2024 · 25 comments · May be fixed by #17635
Open

Braille doesn't work on last snapshot #17502

dreinn opened this issue Dec 11, 2024 · 25 comments · May be fixed by #17635
Assignees
Labels
component/braille p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@dreinn
Copy link

dreinn commented Dec 11, 2024

Steps to reproduce:

Start NVDA, select MDV Lilli display driver.

Actual behavior:

Expected behavior:

NVDA logs, crash dumps and other attachments:

This is what NVDA logs when I press a navigation key from the display braille:
ERROR - scriptHandler.executeScript (09:48:48.268) - MainThread (16984):
error executing script: <bound method GlobalCommands.script_braille_scrollForward of <globalCommands.GlobalCommands object at 0x07C918F0>> with gesture 'RG'
Traceback (most recent call last):
File "scriptHandler.pyc", line 300, in executeScript
File "globalCommands.pyc", line 4034, in script_braille_scrollForward
File "braille.pyc", line 2834, in scrollForward
File "braille.pyc", line 1995, in scrollForward
File "braille.pyc", line 1988, in _nextWindow
File "braille.pyc", line 1890, in _get_windowStartPos
File "braille.pyc", line 1880, in windowPosToBufferPos
ZeroDivisionError: integer division or modulo by zero

System configuration

NVDA portable:

NVDA version: alpha-34735,bdd31537 (2025.1.0.34735)

Windows version: Microsoft Windows [Versione 10.0.19045.4894]

Other questions

Does the issue still occur after restarting your computer? Yes.

Have you tried any other versions of NVDA? If so, please report their behaviors. Yes, it works on all version. 2025.1 seems not compatible.

@nvdaes
Copy link
Collaborator

nvdaes commented Dec 11, 2024

Hello. I cannot reproduce this with the Focus braille display. But I saw this behavior in a previous portable alpha version with an EcoBraille display. I fixed it with a workaround, that was to enable the braille viewer.
Unfortunately I don't have an Ecobraille anymore to test, but you may try to enable the braille viewer to see if this affects this behavior with some braille displays.
As you may know, braille viewer is available from NVDA's menu, tools submenu. I mention how to enable it just in case.
Hope this helps.

@Adriani90
Copy link
Collaborator

I am on last alpha with a Brailliant BI40x and I cannot reproduce this issue.
@burmancomp what Braille display do you have? Can you reproduce?

@burmancomp
Copy link
Contributor

I am writing with nvda_snapshot_alpha-34750,8a82bd5b.exe as portable installation, braille display is caiku albatross 80. All seems to work normally. I have also updated installed version to current alpha at same laptop, and all seems to work normally as well. Os is w11 23h2.

@seanbudd
Copy link
Member

@Emil-18 - see also #17092

@dreinn
Copy link
Author

dreinn commented Dec 13, 2024

I confirm that if I activate the braille viewer, then I can use the display braille correctly.
For the moment, a great thanks to @nvdaes for the work around.
If you need more information for the issue, let me know!

@Adriani90
Copy link
Collaborator

Cc: @bramd , @dkager , @LeonarddeR

@SaschaCowley SaschaCowley added component/braille p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Dec 16, 2024
@SaschaCowley SaschaCowley added this to the 2025.1 milestone Dec 16, 2024
@josephsl
Copy link
Collaborator

josephsl commented Jan 2, 2025

Hi,

Is this happening if NVDA is told to show speech output in braille? If yes, I think we need to combine this issue with #17092 as the cause might be the same.

Thanks.

@SaschaCowley
Copy link
Member

@dreinn are you still having this problem? Could we please get a full debug log?

@SaschaCowley
Copy link
Member

@dreinn are you sure alpha-34735,bdd31537 is the first snapshot to exhibit this behaviour?

@dreinn
Copy link
Author

dreinn commented Jan 21, 2025

@SaschaCowley Oh no! At all! I can only say that on 2024.4 it works properly, but I really don't know from which snapshot there is this bug.

@dreinn
Copy link
Author

dreinn commented Jan 21, 2025

@SaschaCowley I attach here a log file with add-on disabled and debug activated.
The problem is that I can't find any errors about braille.
To clarify, I never hear any error signals, the display apparently loads correctly, but no characters are shown on the display until I activate the braille viewer.
Ah, when I say that the display loads correctly, I mean no errors, but display braille remains died, until I activate the braille viewer.

log no braille.txt

@Adriani90
Copy link
Collaborator

@dreinn could you please post a new log after you enable following advanced logging options in NVDA advanced settings?

  • hwIo
  • Louis
  • GUI
  • Events

Thanks

@dreinn
Copy link
Author

dreinn commented Jan 21, 2025

@SaschaCowley here it is.

log no braille2.log

@LeonarddeR
Copy link
Collaborator

@dreinn Have you tried this with add-ons disabled?

@LeonarddeR
Copy link
Collaborator

I think I know what the problem is. I will provide a possible fix.

@LeonarddeR LeonarddeR linked a pull request Jan 21, 2025 that will close this issue
5 tasks
@dreinn
Copy link
Author

dreinn commented Jan 23, 2025

@LeonarddeR @SaschaCowley Hello, I don't run NVDA from source, so I can't test your fix until it will be included in a snapshot.
Unfortunately I will return at work next tuesday, so, or someone can create a snapshot within the next 7 hours and then I can test, otherwise wait until Tuesday.

@dreinn
Copy link
Author

dreinn commented Jan 23, 2025

I'm sorry @LeonarddeR First of all thank you for having made a snapshot so soon!
Unfortunately I can't try it because the stupid and unuseful antivirus Apex One prevents me to execute it.
Company policies keep this software installed.
There must be some difference between a manually created snapshot and an alpha snapshot, because I can run alphas without problems. Maybe it's a question of certificates, I don't know, but unfortunately I can't use this kind of snapshot.

@dreinn
Copy link
Author

dreinn commented Jan 23, 2025

@LeonarddeR I have an idea, i will replace the driver manually and each file which has to do with braille.
Stay tuned

@LeonarddeR
Copy link
Collaborator

Replacing the drivers won't work here.

@dreinn
Copy link
Author

dreinn commented Jan 23, 2025

nope. Overwriting only the lilli.dll driver doesn't have any effect. So, in order I can test it, please commit your solution to the alpha snapshot system.

@michaelDCurran
Copy link
Member

michaelDCurran commented Jan 23, 2025 via email

@dreinn
Copy link
Author

dreinn commented Jan 23, 2025

yes! it works properly!
Thank you very much to all people that contributed to this issue.

@dreinn dreinn closed this as completed Jan 23, 2025
@LeonarddeR
Copy link
Collaborator

Please do'nt close an issue that is under investigation/that has a pr attached that is not yet merged. Merging the pr will automatically close the issue.

@LeonarddeR LeonarddeR reopened this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/braille p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants