Skip to content

fix(types): improve dynamic slots #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 14, 2025
Merged

fix(types): improve dynamic slots #3857

merged 16 commits into from
Apr 14, 2025

Conversation

sandros94
Copy link
Member

@sandros94 sandros94 commented Apr 10, 2025

πŸ”— Linked issue

CI failing on nuxt/nuxt.com#1853

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This introduces a fallback string to DynamicSlots when working with untyped content

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sandros94 sandros94 self-assigned this Apr 10, 2025
Copy link
Contributor

nuxthub-admin bot commented Apr 10, 2025

βœ… Deployed ui3

Deployed ui3 4d2f214 to preview

πŸ”— fix-dynamic-slot-fallback.ui-6q2.pages.dev
πŸ“Œ ed1c9965.ui-6q2.pages.dev
πŸ“±
View QR Code QR code linking to deployment URL.

πŸ“‹ View deployment logs

Copy link

pkg-pr-new bot commented Apr 10, 2025

npm i https://pkg.pr.new/@nuxt/ui@3857

commit: 4d2f214

@sandros94
Copy link
Member Author

it seems there is an issue between the local development and the dist module. For example locally the auto-complete for slot names it does work, but gets lost in the end-project:

ui playground:
image

nuxt.com repo:
image

@sandros94 sandros94 marked this pull request as draft April 11, 2025 14:12
@Teages
Copy link

Teages commented Apr 11, 2025

related: vuejs/language-tools#5247

The fix was included in the v3.0.0-alpha.0.

@sandros94
Copy link
Member Author

sandros94 commented Apr 11, 2025

related: vuejs/language-tools#5247

The fix was included in the v3.0.0-alpha.0.

Interestingly, the very issue that PR was fixing is the reason why we still haven't upgraded from 2.2.2

doc's typechecking is doing some shady stuff...

@sandros94 sandros94 changed the title type: fix dynamic slots fallback chore: update vue-tsc and fix dynamic slots Apr 12, 2025
@sandros94 sandros94 marked this pull request as draft April 12, 2025 13:30
@sandros94 sandros94 changed the title chore: update vue-tsc and fix dynamic slots type: fix dynamic slots Apr 14, 2025
@benjamincanac benjamincanac changed the title type: fix dynamic slots fix(types): improve dynamic slots Apr 14, 2025
@sandros94 sandros94 marked this pull request as ready for review April 14, 2025 14:07
@benjamincanac benjamincanac merged commit 8dd9d08 into v3 Apr 14, 2025
8 checks passed
@benjamincanac benjamincanac deleted the fix/dynamic-slot-fallback branch April 14, 2025 14:09
@benjamincanac benjamincanac added the v3 #1289 label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants