Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest-environment): respect custom app.baseURL in manifest path #1213

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

danielroe
Copy link
Member

resolves #1212

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I'd advise against using a custom baseURL in testing but this respects it if provided.

@danielroe danielroe self-assigned this Mar 26, 2025
Copy link

pkg-pr-new bot commented Mar 26, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@nuxt/test-utils@1213

commit: 8226c2c

@danielroe danielroe merged commit 0b29982 into main Mar 26, 2025
6 checks passed
@danielroe danielroe deleted the fix/base-url branch March 26, 2025 13:41
@github-actions github-actions bot mentioned this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error fetching app manifest in testing files when baseURL is provided
1 participant