New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright config - Test against branded browsers #1143

Open

NicholasAntidormi opened this issue Feb 24, 2025 · 0 comments

NicholasAntidormi commented Feb 24, 2025

test-utils/examples/app-playwright/playwright.config.ts

Lines 14 to 17 in eea8397

    
             // Test against branded browsers. 
        
             // { ...devices['Desktop Edge'], channel: 'msedge' }, 
        
             // { ...devices['Desktop Chrome'], channel: 'chrome' }, 
        
           ] satisfies Array<string | typeof devices[string]>

I think it should be something like

/* Test against branded browsers. */
{
  name: 'Microsoft Edge',
  use: { ...devices['Desktop Edge'], channel: 'msedge' },
},
{
  name: 'Google Chrome',
  use: { ...devices['Desktop Chrome'], channel: 'chrome' },
}

and the type should something like

satisfies (keyof typeof devices | Project)[]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment